[Bug 1040517] Review Request: julia - High-level, high-performance dynamic language for technical computing
bugzilla at redhat.com
bugzilla at redhat.com
Thu Sep 18 21:03:25 UTC 2014
https://bugzilla.redhat.com/show_bug.cgi?id=1040517
Paulo Andrade <paulo.cesar.pereira.de.andrade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--- Comment #76 from Paulo Andrade <paulo.cesar.pereira.de.andrade at gmail.com> ---
Please remove the installed /usr/share/doc/julia/html/objects.inv
file. This would also removed some rpmlint warnings:
julia-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/julia/html/objects.inv
julia-doc.noarch: W: file-not-utf8 /usr/share/doc/julia/html/objects.inv
I also suggest adding these build requires:
BuildRequires: desktop-file-utils
BuildRequires: ImageMagick
This to somewhere, as appropriate in %install:
mkdir -p %{buildroot}%{_datadir}/pixmaps
convert -scale 32x32 doc/juliadoc/juliadoc/theme/julia/static/julia-logo.svg \
julia-logo.png %{buildroot}%{_datadir}/pixmaps/%{name}.png
mkdir -p %{buildroot}%{_datadir}/applications
cat > %{buildroot}%{_datadir}/applications/%{name}.desktop << EOF
[Desktop Entry]
Name=Julia
Comment=High-level, high-performance dynamic language for technical computing
Exec=julia
Icon=%{name}
Terminal=true
Type=Application
Categories=Science;Math;
EOF
desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
and append this to the main %files:
%{_datadir}/pixmaps/%{name}.png
%{_datadir}/applications/%{name}.desktop
You obviously may customize it, and also, the suggestion for the
.desktop file is untested.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list