[Bug 1145443] Review Request: python-pdfkit - Python 2 wrapper for wkhtmltopdf utility to convert HTML to PDF

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1145443



--- Comment #3 from Eduardo Mayorga <e at mayorgalinux.com> ---
Some initial comments:

- The upstream summary is better IMO. It actually describes the package.

- Your are missing a Requires.
>>> import pdfkit
>>> pdfkit.from_url('http://google.com', 'out.pdf')
which: no wkhtmltopdf in
(/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/usr/bin/mozart2-2.0.0-alpha.0+build.3777.62f3ec5-x86_64-linux/bin:/home/mayorga/.local/bin:/home/mayorga/bin:/usr/bin/mozart2-2.0.0-alpha.0+build.3777.62f3ec5-x86_64-linux/bin)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/pdfkit/api.py", line 22, in from_url
    configuration=configuration)
  File "/usr/lib/python2.7/site-packages/pdfkit/pdfkit.py", line 39, in
__init__
    self.configuration = (Configuration() if configuration is None
  File "/usr/lib/python2.7/site-packages/pdfkit/configuration.py", line 27, in
__init__
    'https://github.com/JazzCore/python-pdfkit/wiki/Installing-wkhtmltopdf' %
self.wkhtmltopdf)
IOError: No wkhtmltopdf executable found: ""
If this file exists please check that this process can read it. Otherwise
please install wkhtmltopdf -
https://github.com/JazzCore/python-pdfkit/wiki/Installing-wkhtmltopdf

wkhtmltopdf is needed at runtime.

Otherwise, it looks fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component