[Bug 1208695] Review Request: liberasurecode - Erasure Code API library written in C with pluggable backends

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1208695



--- Comment #1 from Petr Pisar <ppisar at redhat.com> ---
URL is usable. Ok.

TODO: You can remove trailing `overview' from the URL tag. Even you can replace
the `liberasurecode' word with `%{name}' macro.

TODO: Use real source URL
<https://bitbucket.org/tsg-/liberasurecode/get/v1.0.5.tar.bz2>. Again you can
replace parts with macros.

Source archive is original (SHA-256:
34327a4ababc1b11e4841cd535da073157193cfbe4ef7568d7f46977986cf1e0). Ok.
Patches are good.
Summary verified from REAMDE.md. Ok.
Description is good. Ok.

FIX: Add `Public License' to license tag (src/utils/chksum/md5.c). If you think
the `heavily cut-down "BSD license"' is applies, you should add `(Public
License or Public Domain)'.

FIX: Add `Copyright only' to license tag (src/utils/chksum/crc32.c).

TODO: Document by a spec comment that a following licences cover source
package:
GPLv2+ (missing)
FSFULLR (m4/lt~obsolete.m4)
FSFUL (m4/libtool.m4)
GPLv3+ (m4/ax_gcc_x86_cpuid.m4)

TODO: If called `libtoolize --force --install', you would not have to edit the
libtool in %build section.

TODO: Execute tests.

FIX: Package COPYING file using `%license' macro.

FIX: The `tools' sub-package has no %files section.

FIX: The `devel' sub-package must run-require exact release of the package with
shared libraries. Then you don't have to duplicate COPYING and README.md.

FIX: The build script ignores Fedora's CFLAGS. (I cannot see
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong etc. among gcc
arguments).

FIX: The sources does not build in F23
(http://koji.fedoraproject.org/koji/taskinfo?taskID=9456796):

libtool: link: gcc -O2 -g -Werror -D_GNU_SOURCE=1 -Wall -pedantic -std=c99
-Wl,-z -Wl,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -o alg_sig_test
utils/chksum/alg_sig_test-test_alg_sig.o  ../src/.libs/liberasurecode.so
/home/test/rpmbuild/BUILD/tsg--liberasurecode-4e1290ea61e5/src/builtin/xor_codes/.libs/libXorcode.so
-lpthread -lm -ldl
/bin/ld: utils/chksum/alg_sig_test-test_alg_sig.o: relocation R_X86_64_32
against `.rodata.str1.1' can not be used when making a shared object; recompile
with -fPIC
utils/chksum/alg_sig_test-test_alg_sig.o: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
Makefile:423: recipe for target 'alg_sig_test' failed

This is because not all CFLAGS are passed to the compiler.

Please correct all `FIX' items, consider fixing `TODO' items, and provide new
spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component