[Bug 1210826] Review Request: rubygem-pathspec - Use to match path patterns such as gitignore

bugzilla at redhat.com bugzilla at redhat.com
Sat Apr 11 16:23:44 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1210826



--- Comment #3 from Ken Dreyer <ktdreyer at ktdreyer.com> ---
I imported your SRPM into a Git repo so it's clearer. Here's how I recommend
handling the tests:
https://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-pathspec.git/commit/?id=2957c1fb52216a43e9b6fc94d4fd7d02cf6738d8

I use a small shell script (rubygem-pathspec-generate-tarball.sh) to download
the upstream source zipfile from a GitHub tag, then strip down that zipfile so
it only contains the tests. At that point, %setup can decompress Source2 so
that it appears to be part of the tree.

To fix this upstream, I've submitted
https://github.com/highb/pathspec-ruby/pull/4

Ruby's RSpec library has made some API breaks between 2.x and 3.x, so I've also
updated the .spec there to handle both APIs depending on the %{fedora} version.
This allows the package to build on Fedora 21, 22, and 23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list