[Bug 1173846] Review Request: GBall - The Console Ball and Racket Game

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1173846

Sinny Kumari <ksinny at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ksinny at gmail.com



--- Comment #1 from Sinny Kumari <ksinny at gmail.com> ---
This is unofficial package review -

Issues
------
* Use %make_install macro instead of make install DESTDIR=%{buildroot}
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section

* %license macro should be used to include License 
%license COPYING

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text


Result of fedora-review tool output looks good and pasted below for reference.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gball-1.0-1.fc21.x86_64.rpm
          gball-1.0-1.fc21.src.rpm
gball.x86_64: W: spelling-error %description -l en_US highscore -> high score,
high-score, highs core
gball.src: W: spelling-error %description -l en_US highscore -> high score,
high-score, highs core
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
gball (rpmlib, GLIBC filtered):
    /bin/sh
    gnudos
    info
    libc.so.6()(64bit)
    libgnudos.so.1()(64bit)
    rtld(GNU_HASH)



Provides
--------
gball:
    gball
    gball(x86-64)



Source checksums
----------------
http://sites.google.com/site/mohammedisam2000/home/projects/gball-1.0.tar.gz :
  CHECKSUM(SHA256) this package     :
00cd806f65b301c481ae77a37a7c11e12176c495f5f4c9652c3f7dfe12f4ebe6
  CHECKSUM(SHA256) upstream package :
00cd806f65b301c481ae77a37a7c11e12176c495f5f4c9652c3f7dfe12f4ebe6


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/bin/fedora-review -n gball
Buildroot used: fedora-21-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component