[Bug 1193878] Review Request: qmasterpassword - Stateless Master Password Manager

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1193878



--- Comment #4 from Beat Küng <beat-kueng at gmx.net> ---
(In reply to Sinny Kumari from comment #2)
> This is unofficial review of the package-
> 
> Packaging looks good to me.
> 
> Building package for Fedora rawhide is failing
> http://koji.fedoraproject.org/koji/taskinfo?taskID=9464365 . I think this
> should be fixed first.

The koji error is:
undefined reference to `libscrypt_scrypt(unsigned char const*, unsigned int,
unsigned char const*, unsigned int, unsigned long long, unsigned int, unsigned
int, unsigned char*, unsigned int)'

I've seen this before, it was because of a missing 'extern "C"{' in the header
of the libscrypt library. Just to test it, I added this in my code, and then
koji builds fine [1]. But this must be fixed in the library.

However it is weird because according to [2] all fedora versions since f19 use
the same version of the library. I don't know koji well enough to get to the
bottom of this...

[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=9469356
[2] http://pkgs.fedoraproject.org/cgit/libscrypt.git

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component