[Bug 1211362] Review Request: wildmagic5 - Wild Magic libraries

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1211362



--- Comment #22 from Antonio Trande <anto.trande at gmail.com> ---
(In reply to Paulo Andrade from comment #21)
> Before approving the package, I want information on this:
> 
> 1. Why was this added?
> Requires: libtxc_dxtn, elfutils-libelf-devel
> to the samples package?
> libtxc_dxtn is in rpmfusion, so, it cannot be added to
> an official Fedora package. Please remove the
> libtxc_dxtn requires, and add a documentation about
> it being desirable for better performance. You can spend
> some time checking about status of s3tc patent and
> open source, but as for as 2+ years ago, it was still
> too much uncertain that no distro would use distribute it
> in official, free releases. But things may have changed,
> and AFAIR, the open source implementations of s3tc were
> done in a way that would not "exactly" match the patent
> wording...

It derives from old tests: i thought that those libraries were needed (i have
tested successfully all samples without them). 

> 
> 2. What is the reason to not have %__global_ldflags in
> LDFLAGS? Hint, if you do not know, make a new package
> adding %__global_ldflags to every place you set LDFLAGS.

None. I have added them.

Spec URL: https://sagitter.fedorapeople.org/wm5/wildmagic5.spec
SRPM URL: https://sagitter.fedorapeople.org/wm5/wildmagic5-5.13-9.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component