[Bug 1251247] Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme

Fri Aug 7 19:41:00 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1251247

Sandro Mani <manisandro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Sandro Mani <manisandro at gmail.com> ---
LGTM, approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/plasma/look-and-
     feel(plasma-workspace), /usr/share/plasma(kf5-plasma),
     /usr/share/plasma/desktoptheme(plasma-desktop, kf5-plasma)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in f23-kdm-
     theme
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: f23-kde-theme-23.0-3.fc24.noarch.rpm
          f23-kdm-theme-23.0-3.fc24.noarch.rpm
          f23-kde-theme-23.0-3.fc24.src.rpm
f23-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/plasma/look-and-feel/org.fedoraproject.fedora.twenty.three/contents/components/artwork/background.png
../../../../../../wallpapers/F23/contents/images/1920x1080.png
f23-kdm-theme.noarch: W: dangling-relative-symlink
/usr/share/kde4/apps/kdm/themes/F23/system-logo-white.png
../../../../../pixmaps/system-logo-white.png
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
f23-kde-theme.noarch: W: invalid-url URL:
https://fedorahosted.org/fedora-kde-artwork/ <urlopen error [Errno -5] No
address associated with hostname>
f23-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/plasma/look-and-feel/org.fedoraproject.fedora.twenty.three/contents/components/artwork/background.png
../../../../../../wallpapers/F23/contents/images/1920x1080.png
f23-kdm-theme.noarch: W: invalid-url URL:
https://fedorahosted.org/fedora-kde-artwork/ <urlopen error [Errno -5] No
address associated with hostname>
f23-kdm-theme.noarch: W: dangling-relative-symlink
/usr/share/kde4/apps/kdm/themes/F23/system-logo-white.png
../../../../../pixmaps/system-logo-white.png
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Requires
--------
f23-kde-theme (rpmlib, GLIBC filtered):
    f23-backgrounds-kde
    kde-filesystem
    system-logos

f23-kdm-theme (rpmlib, GLIBC filtered):
    f23-backgrounds-kde
    kde-filesystem
    kdm
    system-logos

Provides
--------
f23-kde-theme:
    f23-kde-theme
    f23-plasma-desktoptheme
    f23-plasma-theme
    system-kde-theme
    system-ksplash-theme
    system-plasma-theme
    systesm-plasma-desktoptheme

f23-kdm-theme:
    f23-kdm-theme
    system-kdm-theme

Source checksums
----------------
https://fedorahosted.org/releases/f/e/fedora-kde-artwork/f23-kde-theme-23.0.tar.bz2
:
  CHECKSUM(SHA256) this package     :
f5958ac3c81bfff927678ccf11eea22d7984d3a1a394daab96088bd57cea1957
  CHECKSUM(SHA256) upstream package :
f5958ac3c81bfff927678ccf11eea22d7984d3a1a394daab96088bd57cea1957

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -b 1251247
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component