[Bug 1241383] Review Request: mkchroot - Fedora Chroot Directory Maker

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1241383



--- Comment #18 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal at gmx.net> ---
> URL:		http://ojuba.org

If there's no web page for this project, pointing at the github repo home would
be the way to go.


There are more capable tools like "mock" and "mach".

Disabling GPG check and bypassing mirror manager is problematic with regard to
security.

The "SRPM URL:" line during review is supposed to point at the src.rpm package.


> Summary: Fedora Chroot Directory Maker

Ambiguous. Misleading. Directories are created with commands like "mkdir". The
%description also doesn't expand on it. The included README is too brief. "to
enabling yum command" is very vague. The script's goal is not explained. It
uses Yum to install package "yum" (and any dependencies) into the chroot
directory, but what exactly that will pull in and what it will result in is
undefined. Does it guarantee that Fedora repo definition files will be
installed? The script contains a couple of lines at the end that are commented
out.


> License: GPLv3

That doesn't match %license.


/usr/bin/mkchroot seems under-developed, half-baked. Overwriting
/etc/yum.repos.d/fcdm.repo and removing it afterwards is highly questionable,
too. This is _not_ inside the chroot.

Else I agree with comment 17.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component