[Bug 1243530] Review Request: winswitch - A tool which allows you to display running applications on other computers

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1243530



--- Comment #29 from Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #8)
> Not a blocker for review, but it would be nice to provide an appdata file
> [https://fedoraproject.org/wiki/Packaging:AppData].
It would be really nice to have an appdata file.

Unfortunately there's more bundling:

witch/net/pybonjour.py -- this is bundled http://code.google.com/p/pybonjour/.
Fortunately the latest upstream version is bundled.

The code in winswitch/twisted also looks a bit suspicious. But those are
snippets of code, not a separate thing. They also appear to be
windows-specific. Please check if they can be removed in %prep.

winswitch/util/pam.py appears to be bundled python-pam. Fedora version is
newer.

Other files look good.

Please own /usr/share/nautilus-python dir.

winswitch.noarch: E: executable-marked-as-config-file /etc/winswitch/firewall
Please remove the executable bit and the #!/bin/sh header.

Requires
--------
winswitch (rpmlib, GLIBC filtered):
    /bin/bash      <---- this one comes from /usr/libexec/winswitch/firewall,
OK.
    /bin/sh        <---- this one comes from /etc/winswitch/firewall, so should
go away when /etc/winswitch/firewall header is removed.
    /usr/bin/env   <---- this one comes from /usr/libexec/winswitch/*. Most
likely those should be edited to use %{__python2}.
    /usr/bin/python2 <---- OK.

More work for you, sorry :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component