[Bug 1203018] Review Request: baculum - WebGUI tool for Bacula Community program

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1203018



--- Comment #35 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael at gmx.net> ---
Skimming over the comments in this ticket, I see comment 19 where Dominik
wrote:

 | I intend to sponsor him once this review is completed.

So why the fuss on devel@ list?

[...]

I find no mentioning of the fedora-review tool.

Please point it at this ticket: fedora-review -b 1203018

It will download the latest package files from the "Spec URL:" and "SRPM URL:"
lines it can find and perform many helpful checks that are relevant during
review. Using it is a basic exercise for new packagers.

[...]

Only displaying the spec files, what's up with the directory ownership?

> %files -f %{name}.lang
> %defattr(-,root,root)
> # directory excluded here, because it needs to be provided
> # with selected web server privileges (lighttpd or apache)
> %{_datadir}/%{name}
> %license LICENSE
> %doc AUTHORS README

That comment is unclear, because there is no %exclude statement in this %files
list.

> %files selinux
> %defattr(-,root,root)
> %{_datadir}/selinux/packages/%{name}/%{name}.pp

Directory %{_datadir}/selinux/packages/%{name} is not included.

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

> %files httpd
> %defattr(-,apache,apache)
> %config(noreplace) %{_sysconfdir}/httpd/conf.d/%{name}.conf
> %config(noreplace) %{_sysconfdir}/%{name}/Data-apache/%{name}.users
> # Apache logs are stored in /var/log/httpd/
> %attr(755,apache,apache) %{_localstatedir}/cache/%{name}/
> %{_sysconfdir}/%{name}/Data-apache/

Directory %{_sysconfdir}/%{name} is not included.

> %files lighttpd
> %defattr(-,lighttpd,lighttpd)
> %config(noreplace) %{_sysconfdir}/%{name}/%{name}-lighttpd.conf
> %config(noreplace) %{_sysconfdir}/%{name}/Data-lighttpd/%{name}.users
> # Lighttpd logs are stored in /var/log/lighttpd
> %attr(755,lighttpd,lighttpd) %{_localstatedir}/cache/%{name}/
> %attr(-,root,root) %{_unitdir}/%{name}-lighttpd.service
> %{_sysconfdir}/%{name}/Data-lighttpd/

Same here.

Since you have both subpackages conflict with eachother, it is clearly a case
of another unowned directory.


The %files lists are ambiguous, too. Watch these two lines as an example:

%config(noreplace) %{_sysconfdir}/%{name}/Data-lighttpd/%{name}.users
%{_sysconfdir}/%{name}/Data-lighttpd/

The second line includes the directory %{_sysconfdir}/%{name}/Data-lighttpd/
and everything below it. That includes also the .users file from the first
line.

  https://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files

There are warnings in the build.log file about those cases.

$ rpmls -p baculum-httpd-7.0.6-0.6.b.fc24.noarch.rpm
drwx------  /etc/baculum/Data-apache
-rw-------  /etc/baculum/Data-apache/baculum.users
-rw-r-----  /etc/httpd/conf.d/baculum.conf
drwxr-xr-x  /var/cache/baculum

And since the directory includes only the .users file, the correct way would be
to turn it into a %dir line in the files list.

Same for the -lighttpd subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component