[Bug 1229349] Review Request: radcli - Radius client library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1229349



--- Comment #7 from Nikos Mavrogiannopoulos <nmavrogi at redhat.com> ---
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/include/radcli
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/include/radcli

Fixed.

> [!]: Spec use %global instead of %define unless justified.
>     Note: %define requiring justification: %{expand:%(echo "%%define
>     myversion %{version}" | sed 's/\./_/g')}

Replaced with global.

> [!]: Rpmlint is run on all installed packages.
>      Note: Mock build failed
>      See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint

That was because of your previous suggestion to combine the description.
Fixed.

> [!]: Package should not use obsolete m4 macros
>      Note: Some obsoleted macros found, see the attachment.
>      See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

Done upstream. Will pull on the next update.
https://github.com/radcli/radcli/commit/295464b056ee8c1de7b0bd1c8aca5b6f31660fe1
https://github.com/radcli/radcli/commit/cf8790b28261046dbc61c03cf01868d00504a694

> 1. If this is a fork, please fix missing license headers.

I'm not sure what you mean here. I've added the headers into the license
breakdown, if that's what you ask.

> 2. AutoTools: Obsoleted m4s found, fix them in the future.

Done upstream.

> 3. Fix [!] issues, and upload new SRPM and SPEC, 

Done.


Updated links:
http://people.redhat.com/nmavrogi/fedora/radcli.spec
http://people.redhat.com/nmavrogi/fedora/radcli-1.2.2-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component