[Bug 1254820] Review Request: php-firephp-firephp-core - Traditional FirePHPCore library for sending PHP variables to the browser

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 22 12:47:02 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1254820

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #3 from Remi Collet <fedora at famillecollet.com> ---
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file README.md is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

  => README.md and each PHP files contain the fulll License text.
     This is enough to comply with MIT License terms.

     Upstream also add the LICENSE.txt file, so this will be part of next
update. 

[!]: Spec file according to URL is the same as in SRPM.
     => Minor acceptable diff (spl not required, so github version is ok)


No Blocker.

=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list