[Bug 1279162] Review Request: connectome-workbench - Connectome Workbench

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1279162

Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek at in.waw.pl
           Assignee|nobody at fedoraproject.org    |zbyszek at in.waw.pl
              Flags|                            |fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> ---
The bad
=======

rm -rf src/build/ should not be necessary.

You should add a desktop file (I see that there's an icon), and also an appdata
file would be great. The desktop file should register for their .spec mimetype
if possible (Upstream is crazy to use .spec extension, but it's probably too
late to fix that).

The License field seems overcomplicated. The License field specifies the
license of the binary package, and since that is compiled with some GPLv3
components, the result must be GPLv3. So unless I'm missing something, the
package is License: GPLv3.

It would be nice to include some example data for people to play around with
the software (which seems pretty nice), without having to download stuff from
the website, especially that it seems that there no direct downloads that are
easy to find.

The ugly
========

wb_view dumps various warnings when run from the commandline. Would be nice to
fix that:

WARNING: Non-ASCII characters were removed, result is "libpng warning: iCCP:
known incorrect sRGB
profile_/usr/bin/wb_view(_ZN5caret15SystemUtilities12getBackTraceERSt6vectorINS_7AStringESaIS2_EE+0x7d)
[0x563be76e8c0d]_/usr/bin/wb_view(_ZN5caret15SystemUtilities12getBackTraceEv+0x4e)
[0x563be76e8d4e]_/usr/bin/wb_view(+0x2b0272)
[0x563be6f86272]_/lib64/libQtCore.so.4(_Z17qt_message_output9QtMsgTypePKc+0x26)
[0x7f470c4d5756]_/lib64/libQtCore.so.4(+0x81941)
[0x7f470c4d5941]_/lib64/libQtCore.so.4(_Z8qWarningPKcz+0xa1)
[0x7f470c4d5bb1]_/lib64/libpng16.so.16(png_chunk_warning+0x40)
[0x7f4705b71240]_/lib64/libpng16.so.16(+0x912c)
[0x7f4705b7012c]_/lib64/libpng16.so.16(+0x1a10a)
[0x7f4705b8110a]_/lib64/libpng16.so.16(png_read_info+0x376)
[0x7f4705b76556]_/lib64/libQtGui.so.4(+0x301145)
[0x7f470cc5c145]_/lib64/libQtGui.so.4(+0x3031dd)
[0x7f470cc5e1dd]_/lib64/libQtGui.so.4(_ZN12QImageReader4readEP6QImage+0x1c4)
[0x7f470cc2b4a4]_/lib64/libQtGui.so.4(_ZN12QImageReader4readEv+0x34)
[0x7f470cc2ba64]_/lib64/libQtGui.so.4(_ZN11QPixmapData8fromFileERK7QStringPKc6QFlagsIN2Qt19ImageConversionFlagEE+0x5a)
[0x7f470cc3f2ba]_/lib64/libQtGui.so.4(_ZN7QPixmap4loadERK7QStringPKc6QFlagsIN2Qt19ImageConversionFlagEE+0x5c4)
[0x7f470cc37cd4]_/usr/bin/wb_view(_ZN5caret13WuQtUtilities10loadPixmapERK7QStringR7QPixmap+0x3d)
[0x563be70525fd]_/usr/bin/wb_view(_ZNK5caret13CursorManager10loadCursorERK7QStringiiRKN2Qt11CursorShapeE+0x45)
[0x563be6fcf9d5]_/usr/bin/wb_view(_ZN5caret13CursorManagerC1Ev+0x156)
[0x563be6fcfbc6]_/usr/bin/wb_view(_ZN5caret10GuiManagerC2EP7QObject+0x20f)
[0x563be6fe7e2f]_/usr/bin/wb_view(_ZN5caret10GuiManager16createGuiManagerEv+0x1d)
[0x563be6fe8add]_/usr/bin/wb_view(main+0x5a8)
[0x563be6f6b8e8]_/lib64/libc.so.6(__libc_start_main+0xf0)
[0x7f47078c9580]_/usr/bin/wb_view(_start+0x29) [0x563be6f860d9]"


WARNING: libpng warning: iCCP: known incorrect sRGB profile
/usr/bin/wb_view(_ZN5caret15SystemUtilities12getBackTraceERSt6vectorINS_7AStringESaIS2_EE+0x7d)
[0x563be76e8c0d]
/usr/bin/wb_view(_ZN5caret15SystemUtilities12getBackTraceEv+0x4e)
[0x563be76e8d4e]
/usr/bin/wb_view(+0x2b0272) [0x563be6f86272]
/lib64/libQtCore.so.4(_Z17qt_message_output9QtMsgTypePKc+0x26) [0x7f470c4d5756]
/lib64/libQtCore.so.4(+0x81941) [0x7f470c4d5941]
/lib64/libQtCore.so.4(_Z8qWarningPKcz+0xa1) [0x7f470c4d5bb1]
/lib64/libpng16.so.16(png_chunk_warning+0x40) [0x7f4705b71240]
/lib64/libpng16.so.16(+0x912c) [0x7f4705b7012c]
/lib64/libpng16.so.16(+0x1a10a) [0x7f4705b8110a]
/lib64/libpng16.so.16(png_read_info+0x376) [0x7f4705b76556]
/lib64/libQtGui.so.4(+0x301145) [0x7f470cc5c145]
/lib64/libQtGui.so.4(+0x3031dd) [0x7f470cc5e1dd]
/lib64/libQtGui.so.4(_ZN12QImageReader4readEP6QImage+0x1c4) [0x7f470cc2b4a4]
/lib64/libQtGui.so.4(_ZN12QImageReader4readEv+0x34) [0x7f470cc2ba64]
/lib64/libQtGui.so.4(_ZN11QPixmapData8fromFileERK7QStringPKc6QFlagsIN2Qt19ImageConversionFlagEE+0x5a)
[0x7f470cc3f2ba]
/lib64/libQtGui.so.4(_ZN7QPixmap4loadERK7QStringPKc6QFlagsIN2Qt19ImageConversionFlagEE+0x5c4)
[0x7f470cc37cd4]
/usr/bin/wb_view(_ZN5caret13WuQtUtilities10loadPixmapERK7QStringR7QPixmap+0x3d)
[0x563be70525fd]
/usr/bin/wb_view(_ZNK5caret13CursorManager10loadCursorERK7QStringiiRKN2Qt11CursorShapeE+0x45)
[0x563be6fcf9d5]
/usr/bin/wb_view(_ZN5caret13CursorManagerC1Ev+0x156) [0x563be6fcfbc6]
/usr/bin/wb_view(_ZN5caret10GuiManagerC2EP7QObject+0x20f) [0x563be6fe7e2f]
/usr/bin/wb_view(_ZN5caret10GuiManager16createGuiManagerEv+0x1d)
[0x563be6fe8add]
/usr/bin/wb_view(main+0x5a8) [0x563be6f6b8e8]
/lib64/libc.so.6(__libc_start_main+0xf0) [0x7f47078c9580]
/usr/bin/wb_view(_start+0x29) [0x563be6f860d9]

The good
========

- latest release is packaged (not counting pre-release)
- Provides/Requires look good
- builds and installs
- %check is present
- software is under an allowed license
- license file is present, %license is used
- no scriptlets are present or necessary

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component