[Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1267890



--- Comment #6 from gil cattaneo <puntogil at libero.it> ---
(In reply to Jerry James from comment #4)
> I only see one very small issue.  In the xsltproc invocation in %build,
> "/usr/share" should be replaced with "%{_datadir}".

> [!]: Package consistently uses macros (instead of hard-coded directory
>      names).
>      In the xsltproc invocation, /usr/share should be replaced with
> %{_datadir}.

Done

> [!]: %check is present and all tests pass.
Maven build style do not use/need %check section. Test suite is tunning in the
%build context

Spec URL: https://gil.fedorapeople.org/jsonld-java-tools.spec
SRPM URL: https://gil.fedorapeople.org/jsonld-java-tools-0.7.0-1.fc23.src.rpm

Thanks!


Request for new package:
https://admin.fedoraproject.org/pkgdb/package/requests/1984
https://admin.fedoraproject.org/pkgdb/package/requests/1985

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component