[Bug 1222334] Review Request: bup - Efficient backup system based on git

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1222334



--- Comment #17 from Tadej Janež <tadej.j at nez.si> ---
Hi William,

thanks for a re-review!

(In reply to William Moreno from comment #9)
> you should ask upstream about python3 support
> as part of:
> 
> http://portingdb-encukou.rhcloud.com/

Agreed, I'll ask upstream about Python3 support.

On a related note, I'm pushing upstream to accept a patch that detects the
correct version of Python 2 and places it as a shebang in all bup commands:
https://groups.google.com/d/msg/bup-list/sF6SC0zNowg/7grBUs5bDgAJ

(In reply to William Moreno from comment #15)
> Last review here:
> https://paste.fedoraproject.org/295213/48646777/

I would suggest that you also paste it here as a comment so the whole review
will be archived here.

> Fix the empty %postun in the spec.

I think this rpmlint warning should be ignored.

Systemd's %systemd_user_postun_with_restart macro is currently defined as
%{nil} [1], hence the rpmlint warning.

However, this may change in the future, so I think it is better to include it
in the SPEC file.


[1]
https://github.com/systemd/systemd/blob/master/src/core/macros.systemd.in#L73

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component