[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #6 from Mikolaj Izdebski <mizdebsk at redhat.com> ---
(In reply to jiri vanek from comment #5)
> > There is no license file installed. You should add license file to upstream
> > repo and install it using %license macro.
> 
> Currently I have no intentions to add license. Maybe I will in some future
> iteration (maybe when We agree with rest of team) But It wil be BSD or some
> other free license for sure.

If it is BSD license then you have to include license text in the package and
there is no way around that.

> > Source0 based on hg repo tip is a bad idea. You should use proper tags
> > (preferably) or revision numbers / commit IDs.
> 
> Sure. For now I had added revision number. In future, when there will be
> releases, it will be replaced by tags.

If you use revision number then Release tag should comply with guidelines at
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages, so
it should be something like 0.1.20151203hg606138e2ec24

> > - Empty sections (%prep, %install) can be removed.
> unless you insists, I would like to keep them in. Just for "look and know"

Sure, that's fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component