[Bug 1282893] Review Request: quantum-espresso - A suite for electronic-structure calculations and materials modeling

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1282893

Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek at in.waw.pl
           Assignee|nobody at fedoraproject.org    |zbyszek at in.waw.pl
              Flags|                            |fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> ---
Hm, what does this do?:

%if 0%{?el6}
%global mpich mpich
%global mpich_load %_mpich_load
%global mpich_unload %_mpich_unload
%else
%global mpich mpich
%global mpich_load %_mpich_load
%global mpich_unload %_mpich_unload
%endif


Requires are normally written with one =. I think == might be misinterpreted.

You can replace the calls to `basename ${f}` with ${f%/*}, makes things
slightly shorter and more readable.

Please use pushd/popd instead of cd/cd -. This is recommended because the path
is printed, which makes logs easier to understand.

%defattr(-,root,root,-) is not needed.

Use %{!?_licensedir:%global license %doc} and then you don't need conditionals
in %files.

Can you comment on the reason for multiple source tarballs? Are they always
released together?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component