[Bug 1287120] Review Request: python-ryu - component-based Software-defined Networking Framework

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1287120



--- Comment #8 from Robert Buchholz <rhbugs at rbu.sh> ---
(In reply to Arie Bregman from comment #7)
> - In %prep, why are you removing requirements files?
> According to Haikel review: "I'd remove *requirements files to prevent pbr
> downloading stuff" 

Is this file generated? I don't see it in the sources and it's not created
during setup.py build.

> - There is no man-page
> not sure I'm following. what should I do about it?

>From what I understand, ryu creates an executable in /usr/bin. That means it
should come with a man page. The Makefile in the doc directory allows creating
man pages using sphinx (this needs additional BuildRequires): make man


> - Is there a reason you're not using %py2_install / %py2_install ? 
> it's not working for me. seems like it can't find such macro.

Which distribution are you building on? Have you tried building in mock? It
works for me in centos-7 and rawhide.

> - Description "This is Python 3 version." could probably us an article.
> what do you mean?

I meant that it should probably say "This is the Python 3 version."

The addition of Python 3 doesn't work unfortunately, as upstream is actually
not Python 3 compatible (SyntaxErrors). It seems conversion is still an ongoing
work there, do you know more?
So this should just build the python2- package only for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component