[Bug 1290450] Review Request: exonerate - A generic tool for sequence alignment

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1290450

Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbyszek at in.waw.pl
           Assignee|nobody at fedoraproject.org    |zbyszek at in.waw.pl
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> ---
--enable-gcov → Why build with coverage? This seems only useful for
development.

Likewise --enable-asserts: all binaries emit the following warning:
** (process:8647): WARNING **: Compiled with assertion checking - will run
slowly
Maybe the slowdown is not too big, in which case it might be worth to leave
this
on, at least initially.

make install DESTDIR=... → %make_install (for brevity)

- license is OK
- license file is present, %license is used
- latest version
- proper build flags are used
- builds and installs OK
- fedora-review doesn't find any issues
- no scriptlets
- requires/provides are OK
- check is present and passes

rpmlint:
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/fastautils.1.gz
59: warning: macro `..' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/fastautils.1.gz
78: warning: macro `L' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/exonerate.1.gz 36:
warning: macro `T' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/exonerate.1.gz 49:
warning: macro `SP' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/exonerate.1.gz
1342: warning: macro `L' not defined
exonerate.x86_64: W: manual-page-warning
/usr/share/man/man1/exonerate-server.1.gz 22: warning: macro `T' not defined
exonerate.x86_64: W: manual-page-warning
/usr/share/man/man1/exonerate-server.1.gz 373: warning: macro `SP' not defined
exonerate.x86_64: W: manual-page-warning
/usr/share/man/man1/exonerate-server.1.gz 449: warning: macro `L' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/ipcress.1.gz 38:
warning: macro `T' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/ipcress.1.gz 71:
warning: macro `SP' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/ipcress.1.gz 261:
warning: macro `L' not defined
They mostly display OK, I'm not sure what those warnings mean exactly.

exonerate.x86_64: E: zero-length /usr/share/doc/exonerate/NEWS
No need to package that then.

exonerate.x86_64: W: no-manual-page-for-binary fastatranslate
exonerate.x86_64: W: no-manual-page-for-binary fastacomposition
exonerate.x86_64: W: no-manual-page-for-binary fastanrdb
exonerate.x86_64: W: no-manual-page-for-binary fastaexplode
exonerate.x86_64: W: no-manual-page-for-binary fasta2esd
exonerate.x86_64: W: no-manual-page-for-binary fastadiff
exonerate.x86_64: W: no-manual-page-for-binary fastaclean
exonerate.x86_64: W: no-manual-page-for-binary fastareformat
exonerate.x86_64: W: no-manual-page-for-binary fastasort
exonerate.x86_64: W: no-manual-page-for-binary fastaindex
exonerate.x86_64: W: no-manual-page-for-binary fastaoverlap
exonerate.x86_64: W: no-manual-page-for-binary fastavalidcds
exonerate.x86_64: W: no-manual-page-for-binary fastasplit
exonerate.x86_64: W: no-manual-page-for-binary fastasoftmask
exonerate.x86_64: W: no-manual-page-for-binary fastasubseq
exonerate.x86_64: W: no-manual-page-for-binary fastaannotatecdna
exonerate.x86_64: W: no-manual-page-for-binary esd2esi
exonerate.x86_64: W: no-manual-page-for-binary fastahardmask
exonerate.x86_64: W: no-manual-page-for-binary fastachecksum
exonerate.x86_64: W: no-manual-page-for-binary fastaclip
exonerate.x86_64: W: no-manual-page-for-binary fastafetch
exonerate.x86_64: W: no-manual-page-for-binary fastalength
exonerate.x86_64: W: no-manual-page-for-binary fastarevcomp
exonerate.x86_64: W: no-manual-page-for-binary fastaremove
3 packages and 0 specfiles checked; 1 errors, 35 warnings.

Too bad ;)

Looks good, except for a few trivial issues. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component