[Bug 1281991] Review Request: fusion-qt4 - Fusion widget style for Qt4

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1281991



--- Comment #2 from Rex Dieter <rdieter at math.unl.edu> ---
1. Naming: ok, but SHOULD follow practice of some other styles using something
like:
qt4-style-fusion

2.  Version/Release: SHOULD: I'd also prefer you used something closer to
recommendations on 
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
like:
Version: 0
Release: 1.hg20151112
(or some better Version: if you have a better idea)

3.  Sources: not ok.   MUST: sources not verifiable, please give url or
script/directions on how to create reproduciable sources

4. macros, mostly ok, except for SHOULD replace
%make_install INSTALL_ROOT=%{buildroot}
with
make install INSTALL_ROOT=%{buildroot}

5.  Since this package is using qt4-devel-private, SHOULD consider adding a
hard versioned dep like:
%{?_qt4_version:Requires: qt4%{?_isa} = %{_qt4_version}}
though probably not important anymore, there's little chance of any new qt4
releases at this point.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component