[Bug 1291558] Review Request: mariadb-java-client - MariaDB connector for java

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1291558

gil cattaneo <puntogil at libero.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |puntogil at libero.it



--- Comment #1 from gil cattaneo <puntogil at libero.it> ---
hi

you must remove:
%global _mavenmetadir /usr/share/maven-metadata
you must explain (as comment in the spec file) why test suite is not executed

you must install license file with %license macro (*also* in javadoc sub
package)

you should remove unnecessary:
# Cleanup
find . -name "*.class" -print -delete
find . -name "*.jar" -print -delete

you should use (to keep timestamp when converting from dos to unix line
ending):
for file in README.md documentation/*.md; do
 sed -i.orig 's|\r||g' $file
 touch -r $file.orig $file
 rm $file.orig
done

instead of
sed -i 's/\r$//' README.md
sed -i 's/\r$//' documentation/Use-MariaDB-Connector-j-driver.md
sed -i 's/\r$//' documentation/About-MariaDB-Connector-J.md
sed -i 's/\r$//' documentation/Developers-Guide.md
sed -i 's/\r$//' documentation/Failover-and-high-availability.md

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component