[Bug 1186900] Review Request: kwave - Sound Editor for KDE

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1186900



--- Comment #4 from Mario Blättermann <mario.blaettermann at gmail.com> ---
(In reply to Pranav Kant from comment #3)
>   Note: Cannot find GNU-LICENSE in rpm(s)
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Licenses should be cloud-safe, that's why we move them to %license from now on:
http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image

> - Large documentation must go in a -doc subpackage. Large could be size
> (~1MB)

Indeed, it is better to move it to a subpackage. I've created a noarch -doc
subpackage which only contains the HTML manuals.

> Generic:
> [!]: Large data in /usr/share should live in a noarch subpackage if package
> is
>      arched.

See above.

> kwave.x86_64: W: gzipped-svg-icon
> ...
> /usr/share/icons/hicolor/scalable/actions/kwave_player_play.svgz

KDE ships gzipped SVGs in many packages. This is no problem so far, but some
software out of KDE is not able to display them. So I have converted the
program icon to PNG in many resolutions, because even Docky can't show the
original and falls back to a generic one.

> kwave.x86_64: W: no-manual-page-for-binary kwave

Would be nice to have a man page, but the kwave binary doesn't have any special
options besides those of Qt and KDE, so it's probably not worth the effort to
write a man page.

> kwave.x86_64: E: non-empty-%post /sbin/ldconfig
> kwave.x86_64: E: non-empty-%postun /sbin/ldconfig

Strange thing... I don't know what this means. Will investigate it.


New files:
Spec URL: https://mariobl.fedorapeople.org/Review/SPECS/kwave.spec
SRPM URL:
https://mariobl.fedorapeople.org/Review/SRPMS/kwave-0.8.99-4.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component