[Bug 1161965] Review Request: python-honcho - Python clone of Foreman

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1161965



--- Comment #3 from Mario Blättermann <mario.blaettermann at gmail.com> ---
%files
%doc README.rst
%{_bindir}/honcho
%{python2_sitelib}/%{pypi_name}
%{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info

%if 0%{?with_python3}
%files -n python3-%{pypi_name}
%doc README.rst
%{_bindir}/honcho
%{python3_sitelib}/%{pypi_name}
%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
%endif # with_python3

The file %{_bindir}/honcho is included in both packages, but py2 and py3
versions of the same module have to be completely independent from each other.
Imagine, someone needs both versions for resolve some dependencies, but this
would end up in a unresolvable file conflict. Have a look at the appropriate
guidelines:
http://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin

Here's the scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8812185

The file %{_bindir}/honcho looks the same in both py2 and py3 package:

#!/usr/bin/python3
# EASY-INSTALL-ENTRY-SCRIPT: 'honcho==0.5.0','console_scripts','honcho'
__requires__ = 'honcho==0.5.0'
import sys
from pkg_resources import load_entry_point

if __name__ == '__main__':
    sys.exit(
        load_entry_point('honcho==0.5.0', 'console_scripts', 'honcho')()
    )

Even the py2 package has the shebang "#!/usr/bin/python3". As I already wrote,
I don't know where you need this for, but if the py3 version works for you,
then just drop the py2 package. Otherwise, rename the "binaries" according to
the guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component