[Bug 1177019] Review Request: os-net-config - Host network configuration tool

bugzilla at redhat.com bugzilla at redhat.com
Fri Feb 6 22:03:17 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1177019

Ben Nemec <bnemec at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(bnemec at redhat.com |
                   |)                           |



--- Comment #3 from Ben Nemec <bnemec at redhat.com> ---
Thanks for the reviews guys.

https://fedorapeople.org/~bnemec/os-net-config.spec
https://fedorapeople.org/~bnemec/os-net-config-0.1.1-2.fc21.src.rpm

-Removed unnecessary systemd requires
-Fixed tab/spaces mismatch
-Build and include docs in the package
-Removed the delorean changelog entry

I did not remove the egg-info files because none of our other OpenStack
packages seem to be doing that and we appear to be regenerating them at build
time anyway.  Also, I think the prohibition around egg files is for egg
packages, whereas we've just got egg metadata.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list