[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1190373



--- Comment #11 from Mario Blättermann <mario.blaettermann at gmail.com> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8938850

The issues from rpmlint:

python3-livestreamer.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python3-livestreamer/html/_static/jquery.js
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

Install the html docs directly instead of adding them to %doc, then run
"dos2unix
%{buildroot}/usr/share/doc/python3-livestreamer/html/_static/jquery.js" at the
end of %install to get a proper line ending.
Moreover, the "install" command should be always called with -p to preserve
timestamps.


python3-livestreamer.noarch: W: hidden-file-or-dir
/usr/share/doc/python3-livestreamer/html/.buildinfo
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

I assume such .buildinfo files are no longer needed once the package has been
installed.


python3-livestreamer.noarch: W: no-manual-page-for-binary python3-livestreamer
Each executable in standard binary directories should have a man page.

rpmlint doesn't recognize the man page correctly. Either rename the man page
file or the script in /usr/bin. This is not only to make rpmlint happy, it's
also less confusing for users.



python3-livestreamer.src: I: checking
python3-livestreamer.src: I: checking-url http://livestreamer.tanuki.se/
(timeout 10 seconds)
python3-livestreamer.src: E: invalid-spec-name
Your spec filename must end with '.spec'. If it's not the case, rename your
file and rebuild your package.

Of course your spec file has the correct ending, but the name doesn't match the
package name anymore since you have changed the package name.


python3-livestreamer.src: I: checking-url
https://projects.archlinux.org/svntogit/community.git/plain/trunk/plugins-hitbox-Refactor-to-use-the-StreamMapper.patch
(timeout 10 seconds)
python3-livestreamer.src: W: invalid-url Patch0:
https://projects.archlinux.org/svntogit/community.git/plain/trunk/plugins-hitbox-Refactor-to-use-the-StreamMapper.patch
HTTP Error 404: Not found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

Doesn't matter in this case, patches are not forced to have an URL, but this
would be the right one:
https://projects.archlinux.org/svntogit/community.git/plain/trunk/plugins-hitbox-Refactor-to-use-the-StreamMapper.patch?h=packages/livestreamer
But you are free to just use the local file name instead.


%{_mandir}/man1/%{module}.1.gz

Don't use a certain extension for compressed man pages. Well, currently we use
gzip, but this could change in the future. Better use a wildcard:

%{_mandir}/man1/%{module}.1.*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component