[Bug 1106415] Review Request: sayonara - A lightweight Qt Audio player

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1106415

Mario Blättermann <mario.blaettermann at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann at gmail.co
                   |                            |m



--- Comment #6 from Mario Blättermann <mario.blaettermann at gmail.com> ---
"BuildRequires:  gstreamer1-devel" is redundant, it is pulled in by
gstreamer1-plugins-base-devel.

Is svn really a runtime requirement? If this points to the tarball creation, it
is not needed.

According to the "licensecheck" output, the license is GPLv3+.

The package installs icons in /usr/share/icons/hicolor, that's why "Requires:
hicolor-icon-theme" is needed.

The file license.txt needs to be added to %files under %license.

What about the Java stuff in sayonara_client?

Would be nice to have an *appdata.xml file to let the program also appear in
future gnome-software versions. Maybe you could contact upstream to add one. 


>From the *.desktop file:

Categories=Audio;Music;Player;AudioVideo;

The last category is not a secondary one, referring to the Freedesktop
specification (see
http://standards.freedesktop.org/menu-spec/latest/apas02.html), and actually
Sayonara don't seem to be a video player. Better remove this category, or put
it as a primary category and remove "Audio".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component