[Bug 1106415] Review Request: sayonara - A lightweight Qt Audio player

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1106415



--- Comment #8 from MartinKG <mgansser at alice.de> ---
(In reply to Mario Blättermann from comment #6)
> "BuildRequires:  gstreamer1-devel" is redundant, it is pulled in by
> gstreamer1-plugins-base-devel.
> 
> Is svn really a runtime requirement? If this points to the tarball creation,
> it is not needed.
> 
deleted

> According to the "licensecheck" output, the license is GPLv3+.
> 
corrected

> The package installs icons in /usr/share/icons/hicolor, that's why
> "Requires: hicolor-icon-theme" is needed.
> 
added

> The file license.txt needs to be added to %files under %license.
>
added

> What about the Java stuff in sayonara_client?
> 
deleted

> Would be nice to have an *appdata.xml file to let the program also appear in
> future gnome-software versions. Maybe you could contact upstream to add one. 
> 
added, reported upstream
> 
> From the *.desktop file:
> 
> Categories=Audio;Music;Player;AudioVideo;
> 
> The last category is not a secondary one, referring to the Freedesktop
> specification (see
> http://standards.freedesktop.org/menu-spec/latest/apas02.html), and actually
> Sayonara don't seem to be a video player. Better remove this category, or
> put it as a primary category and remove "Audio".
corrected

new rpm files upload

Spec URL: https://www.dropbox.com/s/2cnhsow8i72mput/sayonara.spec?dl=0
SRPM URL:
https://www.dropbox.com/s/g5j7pwwk5omq55c/sayonara-0.6.2-2.svn1016.fc21.src.rpm?dl=0

%changelog
* Mon Feb 16 2015 Martin Gansser <martinkg at fedoraproject.org> - 0.6.2-2.svn1016
- deleted BR  gstreamer1-devel because its redundant
- deleted RR svn isn't needed
- corrected license tag to GPLv3+
- added RR hicolor-icon-theme
- mark license files as %%license where available
- added appdata.xml file
- modified desktop file Categories
- removed java stuff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component