[Bug 1158872] Review Request: diorite - Utility and widget library for Nuvola Player

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1158872

Mario Blättermann <mario.blaettermann at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mario.blaettermann at gmail.co
                   |                            |m
           Assignee|nobody at fedoraproject.org    |mario.blaettermann at gmail.co
                   |                            |m
              Flags|                            |fedora-review?



--- Comment #3 from Mario Blättermann <mario.blaettermann at gmail.com> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8954688

Some initial comments:

%files devel
%{_libdir}/pkgconfig/diorite*.pc
%{_includedir}/diorite-1.0/dioriteglib-0.1.h
%{_includedir}/diorite-1.0/dioritegtk-0.1.h

The directory %{_includedir}/diorite-1.0/ stays unowned this way. Why not use
simply use a wildcard:
%{_includedir}/diorite-1.0/*

"Requires: pkgconfig" in the -devel package is superfluous, see here:

$ rpm -qpR ./diorite-devel-0.1-0.3git2dee74a.fc21.i686.rpm
/usr/bin/pkg-config
diorite(x86-32) = 0.1-0.3git2dee74a.fc21
pkgconfig
pkgconfig(dioriteglib-0.1)
pkgconfig(glib-2.0)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1


$ rpmlint -i -v *
diorite.i686: I: checking
diorite.i686: W: incoherent-version-in-changelog 0.1-0.3git2dee74e
['0.1-0.3git2dee74a.fc21', '0.1-0.3git2dee74a']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

There is something wrong with the version tag, don't know exactly what. Have a
look at the naming guidelines.

The package installs *.so files in the default linker paths, so /sbin/ldconfig
is needed in %post.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component