[Bug 902086] Review request: Elasticsearch

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=902086



--- Comment #132 from jiri vanek <jvanek at redhat.com> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #131)
> Issues:
> - please reflow %description into paragraphs separated with empty lines. rpm
> -i and other tools treat it as preformatted text and it looks a bit ugly
> right now.

fixed
> 
> - In %files javadoc move NOTICE.txt to %license too.

fixed
> 
> - I don't understand the change with R:jpackage-utils, R:java-headless. You
> mention #1194110 as the reason, but that bug was about missing dependency on
> xmvn-resolve. mvn-resolve is not needed iiuc, so why not remove this?
> 
on your responsibility! fixed!

> - R:java-base64 >= 2.3.8-7 is also needed. BR is not enough.
> 

ah sure, auto mvn deps donot handle version. sorry.

> 
> - /var/lib/elasticsearch should be owned by elasticsearch. You need to add
> %attr in the %files section. See
> http://www.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html.

sorry, I read it as owned by packge es. user es is owning it now.
> 
> - When the daemon is started, is still listens on [::]:9200 and [::]:9300.
> The daemon has to be fixed to not accept commands from the network in the
> default configuration.

This is default upstream behaviour. Not packaging issue. It is worthy to be
bugged as separate bug and to fix as different issue then pkg review.
updated to 1.4.4. although it really should be fixed, and fixed soon, it should
not be an initial push blocker.

SPEC:
https://jvanek.fedorapeople.org/elasticsearch/review/v7/elasticsearch.spec
SRPM:
https://jvanek.fedorapeople.org/elasticsearch/review/v7/elasticsearch-1.4.4-0.fc23.src.rpm

ty for check!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component