[Bug 1195054] Review Request: php-pear-Net-LDAP2 - Object oriented interface for searching and manipulating LDAP-entries

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1195054

Jon Ciesla <limburgher at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody at fedoraproject.org    |limburgher at gmail.com
              Flags|                            |fedora-review+



--- Comment #2 from Jon Ciesla <limburgher at gmail.com> ---
Good:

- rpmlint checks return:

php-pear-Net-LDAP2.src: W: spelling-error %description -l en_US LDAPs -> Laps,
Leaps, Lapps
The value of this tag appears to be misspelled. Please double-check.

php-pear-Net-LDAP2.src: W: spelling-error %description -l en_US ldap -> lap,
leap, dapple
The value of this tag appears to be misspelled. Please double-check.

Ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license ( LPGLv3 ) OK
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Everything looks great.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component