[Bug 1175302] Review Request: ksysguard - KDE Process Management application

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1175302

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jgrulich at redhat.com
              Flags|                            |needinfo?(jgrulich at redhat.c
                   |                            |om)



--- Comment #1 from Rex Dieter <rdieter at math.unl.edu> ---
naming: ok

1. SHOULD use better project url, suggest:
URL: https://projects.kde.org/projects/kde/workspace/ksysguard


2. license NOT ok, some sources are GPLv2 only so MUST use:
License: GPLv2

sources: ok
3b2e23fc9e758741f26d1edb6120ea3d  ksysguard-5.1.1.tar.xz


3. SHOULD prefer/use
make install/fast DESTDIR=%{buildroot}
over
%make_install 


4. SHOULD verify if scriptlets
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
are needed for special-case kdeinit shlib:
%{_kf5_libdir}/libkdeinit5_ksysguard.so


5. MUST validate included application .desktop file, add
BuildRequires: desktop-file-utils
and
%check
desktop-file-validate %{buildroot}%{_datadir}/applications/ksysguard.desktop

6.  MUST add icon cache scriptlets for included
%{_datadir}/icons/hicolor/*/apps/*.png

7. SHOULD use %find_lang ... --with-kde ... to automatically pick up HTML
handbooks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component