[Bug 1179947] Review Request: python-parsley - Parsing and pattern matching made easy

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1179947

Eduardo Echeverria <echevemaster at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |echevemaster at gmail.com
           Assignee|nobody at fedoraproject.org    |echevemaster at gmail.com
              Flags|fedora-review?              |fedora-review-



--- Comment #1 from Eduardo Echeverria <echevemaster at gmail.com> ---
Hi Robert, some comments.

- in terml/test/test_terml.py file there are an import:
from twisted.trial import unittest
so, you will need python-twisted for running these tests.

- The package contains tests is good practice, running it.

- The package contains documentation, please build with python-sphinx.

- Don't use wildcards listing the files or trailing slash, just list directly
the directory
%{python2_sitelib}/ometa instead %{python2_sitelib}/ometa/*

-Don't ship eggs directly from the code, rebuild it. (Just remove the bundled
egg in %prep section)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component