[Bug 1179804] Review Request: python-nine - Python 2 / 3 compatibility, like six, but favouring Python 3

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1179804

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review?



--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> ---
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
python3-nine.x86_64: W: spelling-error Summary(en_US) favouring -> favoring,
flavoring
python3-nine.x86_64: W: spelling-error %description -l en_US https -> HTTP
python3-nine.x86_64: W: spelling-error %description -l en_US pypi -> typify
python3-nine.x86_64: W: spelling-error %description -l en_US writeth -> writhe,
writer, write
python3-nine.x86_64: W: spelling-error %description -l en_US worketh ->
worksheet
python3-nine.x86_64: W: spelling-error %description -l en_US codebase -> co
debase, co-debase, code base
python-nine.src: W: spelling-error Summary(en_US) favouring -> favoring,
flavoring
python-nine.src: W: spelling-error %description -l en_US https -> HTTP
python-nine.src: W: spelling-error %description -l en_US pypi -> typify
python-nine.src: W: spelling-error %description -l en_US writeth -> writhe,
writer, write
python-nine.src: W: spelling-error %description -l en_US worketh -> worksheet
python-nine.src: W: spelling-error %description -l en_US codebase -> co debase,
co-debase, code base
python-nine.x86_64: W: spelling-error Summary(en_US) favouring -> favoring,
flavoring
python-nine.x86_64: W: spelling-error %description -l en_US https -> HTTP
python-nine.x86_64: W: spelling-error %description -l en_US pypi -> typify
python-nine.x86_64: W: spelling-error %description -l en_US writeth -> writhe,
writer, write
python-nine.x86_64: W: spelling-error %description -l en_US worketh ->
worksheet
python-nine.x86_64: W: spelling-error %description -l en_US codebase -> co
debase, co-debase, code base
python-nine.x86_64: E: no-binary
python-nine-debuginfo.x86_64: E: empty-debuginfo-package
4 packages and 0 specfiles checked; 2 errors, 18 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball     :
fe1723ca5d3db5cb28a861dca9da1a4a0ce3614057fb07279ddb4905415d3aff
upstream tarball :
fe1723ca5d3db5cb28a861dca9da1a4a0ce3614057fb07279ddb4905415d3aff

+ License "Public Domain" is valid and included in LICENSE.rst file

Suggestions:
1) This package is a noarch package please add
BuildArch:      noarch

2) Group tag is not needed even on EPEL6 so if you are not planning this
package for el5, you can safely remove it though its not mandatory to remove.

3) as this is noarch package you can remove CFLAGS in %build

Rest looks simple and fine :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component