[Bug 1176595] Review Request: hypre - High performance matrix preconditioners

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1176595

Sinny Kumari <ksinny at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ksinny at gmail.com



--- Comment #4 from Sinny Kumari <ksinny at gmail.com> ---
This is un-official review of the package

Few suggestions in spec file:
* In BuildRequires section, it is preferred to write each build require package
in new line unless they are related. For example in your spec file you can
write gcc-c++ and  gcc-gfortran in same line, libtool and libtool-ltdl-devel in
one line.

* In %files section, %defattr is not needed unless you are changing default
permission

Also, its good to give successful scratch build link of package in koji

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component