[Bug 1182261] Review Request: libabigail - Tool for constructing, manipulating, serializing and de-serializing ABI-relevant artifacts

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1182261

Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.michael at gmx.net



--- Comment #7 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael at gmx.net> ---
> %global checkout git.%{git_revision}
> Release: 0.1.%{checkout}%{?dist}

Fedora's packaging guidelines want you to include the checkout date her as a
prefix:

  https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages


> BuildRequires: gzip

https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2


> Requires: elfutils

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

TLDR: Add a comment that gives the rationale why this explicit Requires are
necessary.


> %package -n libabigail-devel
> Provides: libabigail-devel = %{version}-%{release}

That's a very unusual explicit Provides you should delete. It's the same that's
added by rpmbuild automatically! ;)


> %package -n libabigail-doc
> Provides: libabigail-doc = %{version}-%{release}

Same here.

> Requires: %{name} = %{version}-%{release}

Please keep Documentation packages completely separate from any such
dependencies, so they can be installed without pulling in stuff that's not
needed. Unless the documentation can only be displayed with a program included
in a separate package. That's not true for HTML files, manual pages and Info
pages.

Not shipping the section 7 manual pages in the same package as the tools
themselves is a packaging bug.

Blocker: The license files are not included! They must be included in the base
package (and preferably also in the separate -doc package to be complete):
https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing


> %check

The section is executed _after_ %install, so it should be placed below %install
in the spec file. (Btw, this is especially true, if the test-suite were to be
run on %buildroot contents.)


> %{_infodir}/abigail.info.gz

Not a blocker, but just like manual files are included with a '*' wildcard
suffix instead of ".gz", doing that also for Info files would be more flexible
(with regard to disabling/customising the compression technique used by the
build system).


> %post -n libabigail-doc
> /sbin/ldconfig

> %postun -n libabigail-doc
> /sbin/ldconfig

Why is ldconfig run here?


> https://kojipkgs.fedoraproject.org//work/tasks/3547/8623547/build.log

Build output is non-verbose. You cannot see whether Fedora's global
compiler/linker flags are used, and you cannot easily verify what options are
used during compilation:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

Try passing V=1 to make, or configure with --disable-silent-rules, or look for
extra build options, or patch the Makefile(s) if necessary.


=> Some more work on this package is needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component