[Bug 1181118] Review Request: globus-net-manager - Globus Toolkit - Globus Network Manager

Sun Jan 18 16:59:43 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1181118

--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> ---
- Please add %license (and a workaround for epel7)
- I still think the description could be reworded to more concisely describe
the functionality of the globus framework, but I leave it to your
consideration.

Issues:
=======
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
Fine. A plugin.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "GPL (v2 or later)", "Unknown or generated". 12 files
     have unknown license. Detailed output of licensecheck in /var/tmp/1181118
     -globus-net-manager/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/include/globus
globus-common-devel owns it.

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
EPEL5 compat.

[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: Buildroot is not present
     Note: Buildroot: present but not needed
[-]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in globus-xio-
     net-manager-driver-devel , globus-net-manager-doc
It's there.

[x]: Package functions as described.
[x]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Scriptlets must be sane, if used.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: globus-net-manager-0.6-1.fc22.x86_64.rpm
          globus-net-manager-devel-0.6-1.fc22.x86_64.rpm
          globus-xio-net-manager-driver-0.6-1.fc22.x86_64.rpm
          globus-xio-net-manager-driver-devel-0.6-1.fc22.x86_64.rpm
          globus-net-manager-doc-0.6-1.fc22.noarch.rpm
          globus-net-manager-0.6-1.fc22.src.rpm
globus-net-manager-devel.x86_64: W: only-non-binary-in-usr-lib
globus-net-manager-devel.x86_64: W: no-documentation
globus-xio-net-manager-driver.x86_64: E: invalid-soname
/usr/lib64/libglobus_xio_net_manager_driver.so
libglobus_xio_net_manager_driver.so
globus-xio-net-manager-driver.x86_64: W: no-documentation
globus-xio-net-manager-driver-devel.x86_64: W: only-non-binary-in-usr-lib
globus-xio-net-manager-driver-devel.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 1 errors, 5 warnings.

Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root at bupkis /]# rpmlint globus-net-manager
globus-xio-net-manager-driver globus-xio-net-manager-driver-devel globus-net- 
manager-devel globus-net-manager-doc
globus-net-manager.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libglobus_net_manager.so.0.0.6 /tmp/tmpwjYWki/lib64/nosync.so
mock (?) bug.

globus-xio-net-manager-driver.x86_64: E: invalid-soname
/usr/lib64/libglobus_xio_net_manager_driver.so
libglobus_xio_net_manager_driver.so
Should be fine.

globus-xio-net-manager-driver.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libglobus_xio_net_manager_driver.so /tmp/tmpwjYWki/lib64/nosync.so
globus-xio-net-manager-driver.x86_64: W: no-documentation
globus-xio-net-manager-driver-devel.x86_64: W: only-non-binary-in-usr-lib
globus-xio-net-manager-driver-devel.x86_64: W: no-documentation
globus-net-manager-devel.x86_64: W: only-non-binary-in-usr-lib
globus-net-manager-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 1 errors, 7 warnings.
]0;<mock-chroot><mock-chroot>[root at bupkis /]# echo 'rpmlint-done:'

OK.

Requires
--------
globus-net-manager (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    globus-common(x86-64)
    globus-xio(x86-64)
    libc.so.6()(64bit)
    libglobus_common.so.0()(64bit)
    libglobus_common.so.0(GLOBUS_COMMON_14)(64bit)
    libpython2.7.so.1.0()(64bit)
    rtld(GNU_HASH)

globus-xio-net-manager-driver (rpmlib, GLIBC filtered):
    globus-net-manager(x86-64)
    libc.so.6()(64bit)
    libglobus_common.so.0()(64bit)
    libglobus_common.so.0(GLOBUS_COMMON_14)(64bit)
    libglobus_net_manager.so.0()(64bit)
    libglobus_xio.so.0()(64bit)
    rtld(GNU_HASH)

globus-xio-net-manager-driver-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    globus-net-manager-devel(x86-64)
    globus-xio-net-manager-driver(x86-64)

globus-net-manager-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    globus-common-devel(x86-64)
    globus-net-manager(x86-64)
    globus-xio-devel(x86-64)
    libglobus_net_manager.so.0()(64bit)
    pkgconfig(globus-common)
    pkgconfig(globus-xio)

globus-net-manager-doc (rpmlib, GLIBC filtered):

Provides
--------
globus-net-manager:
    globus-net-manager
    globus-net-manager(x86-64)
    libglobus_net_manager.so.0()(64bit)

globus-xio-net-manager-driver:
    globus-xio-net-manager-driver
    globus-xio-net-manager-driver(x86-64)
    libglobus_xio_net_manager_driver.so()(64bit)

globus-xio-net-manager-driver-devel:
    globus-xio-net-manager-driver-devel
    globus-xio-net-manager-driver-devel(x86-64)
    pkgconfig(globus-xio-net-manager-driver)

globus-net-manager-devel:
    globus-net-manager-devel
    globus-net-manager-devel(x86-64)
    pkgconfig(globus-net-manager)

globus-net-manager-doc:
    globus-net-manager-doc

Unversioned so-files
--------------------
globus-xio-net-manager-driver: /usr/lib64/libglobus_xio_net_manager_driver.so

Source checksums
----------------
http://www.globus.org/ftppub/gt6/packages/globus_net_manager-0.6.tar.gz :
  CHECKSUM(SHA256) this package     :
4b50d68a64c77f89b91ad1e196520f59d0324942afdbb3d71e4d6a2d24b0ded8
  CHECKSUM(SHA256) upstream package :
4b50d68a64c77f89b91ad1e196520f59d0324942afdbb3d71e4d6a2d24b0ded8

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1181118 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component