[Bug 1173205] Review Request: nodejs-dependency-lister - Lists your module's dependencies with URLs and licenses

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 18 20:42:53 UTC 2015 

https://bugzilla.redhat.com/show_bug.cgi?id=1173205

Piotr Popieluch <piotr1212 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #4 from Piotr Popieluch <piotr1212 at gmail.com> ---
APPROVED.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 3 files have unknown license. Detailed output of
     licensecheck in /home/piotr/rpmbuild/1173205-nodejs-dependency-
     lister/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-dependency-lister-1.0.0-1.fc22.noarch.rpm
          nodejs-dependency-lister-1.0.0-1.fc22.src.rpm
nodejs-dependency-lister.noarch: W: only-non-binary-in-usr-lib
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/bluebird
/usr/lib/node_modules/bluebird
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/npm-stats
/usr/lib/node_modules/npm-stats
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/semver
/usr/lib/node_modules/semver
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/as-number
/usr/lib/node_modules/as-number
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/yargs
/usr/lib/node_modules/yargs
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/minstache
/usr/lib/node_modules/minstache
nodejs-dependency-lister.noarch: W: no-manual-page-for-binary dependency-lister
2 packages and 0 specfiles checked; 0 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root at pontifex /]# rpmlint
nodejs-dependency-lister
nodejs-dependency-lister.noarch: W: only-non-binary-in-usr-lib
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/bluebird
/usr/lib/node_modules/bluebird
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/npm-stats
/usr/lib/node_modules/npm-stats
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/semver
/usr/lib/node_modules/semver
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/as-number
/usr/lib/node_modules/as-number
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/yargs
/usr/lib/node_modules/yargs
nodejs-dependency-lister.noarch: W: dangling-symlink
/usr/lib/node_modules/dependency-lister/node_modules/minstache
/usr/lib/node_modules/minstache
nodejs-dependency-lister.noarch: W: no-manual-page-for-binary dependency-lister
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
]0;<mock-chroot><mock-chroot>[root at pontifex /]# echo 'rpmlint-done:'



Requires
--------
nodejs-dependency-lister (rpmlib, GLIBC filtered):
    /usr/bin/env
    nodejs(engine)
    npm(as-number)
    npm(bluebird)
    npm(minstache)
    npm(npm-stats)
    npm(semver)
    npm(yargs)



Provides
--------
nodejs-dependency-lister:
    nodejs-dependency-lister
    npm(dependency-lister)



Source checksums
----------------
http://registry.npmjs.org/dependency-lister/-/dependency-lister-1.0.0.tgz :
  CHECKSUM(SHA256) this package     :
921cd1441d099bacae7e09ca30a681a2a4c4b6ac3ae25555df0d9e56ed5228f8
  CHECKSUM(SHA256) upstream package :
921cd1441d099bacae7e09ca30a681a2a4c4b6ac3ae25555df0d9e56ed5228f8
https://raw.githubusercontent.com/mattdesl/dependency-lister/master/test.js :
  CHECKSUM(SHA256) this package     :
02ad4af2f35f8844f2228998c1149bb2dcde90d04d17b9d8efb4b2ecdb40b5ea
  CHECKSUM(SHA256) upstream package :
02ad4af2f35f8844f2228998c1149bb2dcde90d04d17b9d8efb4b2ecdb40b5ea


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1173205
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

More information about the package-review mailing list