[Bug 1128754] Review Request: mozilla-requestpolicy - Firefox and Seamonkey extension that gives you control over cross-site requests

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1128754



--- Comment #4 from Paulo Andrade <paulo.cesar.pereira.de.andrade at gmail.com> ---
I would like some comments about these "===== MUST items =====":

1. It says License GPLv3+ and LGPLv3+ MPLv2
I believe it is LGPLv2.1+ (the icons) and not LGPLv3+. Please verify.
I believe the MPLv2 are only the tests, so, MPLv2 should be only sources,
not installed files. Please verify.
"""
[ ]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
"""
The license tag should also have an extra "and" if keeping as is, that is:
-GPLv3+ and LGPLv3+ MPLv2
+GPLv3+ and LGPLv3+ and MPLv2

2. It is the owner of %{firefox_inst_dir} and %{seamonkey_inst_dir}
This looks wrong. Too bad firefox-filesystem is not the onwer of
%{firefox_inst_dir}, but there are other packages that think they are the
owner.
seamonkey is the owner of %{seamonkey_inst_dir}.
I think it should be worth a bug report for firefox-filesystem for it to become
owner of %{firefox_inst_dir}
"""
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/mozilla/extensions
     /{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}(mozilla-esteid, seamonkey,
     mozilla-https-everywhere)
"""

3. Please correct:
"""
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
"""

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component