[Bug 1185015] Review Request: gap-pkg-browse - GAP browser for 2-dimensional arrays of data

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1185015



--- Comment #2 from Jerry James <loganjerry at gmail.com> ---
(In reply to Sandro Mani from comment #1)
> Same comments as in https://bugzilla.redhat.com/show_bug.cgi?id=1185014#c1
> (except for license), but all in all ok.

I have made the same fixes to this spec file, namely marking the documentation
directory as %docdir and adding Requires(post) and Requires(postun).

> Only additional thing:
> [!]: %build honors applicable compiler flags or justifies otherwise.
> Consider adding
> 
> LDFLAGS="%{__global_ldflags}"
> 
> to make (despite these currently being the same as the default flags, but
> i.e. %cmake etc. also explicitly set these).

Done (although I used $RPM_LD_FLAGS, but it has the same effect).

New URLs:
Spec URL: https://jjames.fedorapeople.org/gap-pkg-browse/gap-pkg-browse.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-browse/gap-pkg-browse-1.8.6-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component