[Bug 1230867] Review Request: felix-scr - Apache Felix Declarative Services Runtime

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1230867



--- Comment #17 from Jie Kang <jkang at redhat.com> ---
(In reply to Mikolaj Izdebski from comment #13)
> Issues:
> 1) spec file must be named "%{name}.spec", where %{name} is component name,
> in this case "felix-scr"
> 2) LICENSE and NOTICE must be installed as %license
> 
> Otherwise looks good. I will post full review once the above problems are
> resolved.

I've fixed the name of the spec file in the srpm and added LICENSE and NOTICE
from the tarball under %license.

SPEC URL: https://jkang.fedorapeople.org/felix-scr.spec
SRPM URL: https://jkang.fedorapeople.org/felix-scr-1.6.2-3.fc21.src.rpm


Please let me know of any other issues to address.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component