[Bug 1231458] Review Request: osmpbf - C library to read and write OpenStreetMap PBF files
bugzilla at redhat.com
bugzilla at redhat.com
Sun Jul 12 15:05:23 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1231458
Jeff Backus <jeff.backus at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.backus at gmail.com
Assignee|nobody at fedoraproject.org |jeff.backus at gmail.com
Flags| |fedora-review?
--- Comment #7 from Jeff Backus <jeff.backus at gmail.com> ---
Hi Tom,
I reviewed your package. Thanks to all of the input from Antti and Michael, not
much for me to add. I did have a few things, though:
* I'm still getting the following error:
/usr/include/osmpbf/fileformat.pb.h:9:42: fatal error:
google/protobuf/stubs/common.h: No such file or directory
Looks like the -devel package needs to Requires: protobuf-devel.
* Please provide links to koji builds to verify that package builds on all
primary arches
* Please put only one item per BuildRequires or Requires entry. It makes it
easier to read. This is an ask, not a requires - but pretty please? :)
Regards,
Jeff
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v3 or later)", "Unknown or generated". 4 files have
unknown license. Detailed output of licensecheck in
/mnt/storage/backed_up/homes/jeff/tmp/reviews/osmbpf/review-
osmpbf/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Package functions as described.
I'm still getting:
/usr/include/osmpbf/fileformat.pb.h:9:42: fatal error:
google/protobuf/stubs/common.h: No such file or directory
Looks like the -devel package needs a Requires: protobuf-devel.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
Addressed in patch...
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: Package should compile and build into binary rpms on all supported
architectures.
Koji builds?
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: osmpbf-1.3.3-4.20150608git3730430.fc22.i686.rpm
osmpbf-devel-1.3.3-4.20150608git3730430.fc22.i686.rpm
osmpbf-1.3.3-4.20150608git3730430.fc22.src.rpm
osmpbf-devel.i686: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (debuginfo)
-------------------
Checking: osmpbf-debuginfo-1.3.3-4.20150608git3730430.fc22.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
osmpbf-devel.i686: W: no-documentation
osmpbf.i686: W: unused-direct-shlib-dependency /usr/lib/libosmpbf.so.1.3.3
/lib/libm.so.6
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
Requires
--------
osmpbf-devel (rpmlib, GLIBC filtered):
libosmpbf.so.1
osmpbf(x86-32)
osmpbf (rpmlib, GLIBC filtered):
/sbin/ldconfig
libc.so.6
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libm.so.6
libprotobuf.so.8
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
rtld(GNU_HASH)
Provides
--------
osmpbf-devel:
osmpbf-devel
osmpbf-devel(x86-32)
osmpbf:
libosmpbf.so.1
osmpbf
osmpbf(x86-32)
Source checksums
----------------
https://github.com/scrosby/OSM-binary/archive/37304305779795ad6fe6a54f7d3f1abea761fba4/OSM-binary-37304305779795ad6fe6a54f7d3f1abea761fba4.tar.gz
:
CHECKSUM(SHA256) this package :
c99113a18dd04cb28ff41b50ddca4c1450e3aef9dbc3e9f70f898b8a2c20b1b1
CHECKSUM(SHA256) upstream package :
c99113a18dd04cb28ff41b50ddca4c1450e3aef9dbc3e9f70f898b8a2c20b1b1
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -n osmpbf
Buildroot used: fedora-22-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list