[Bug 1242056] Review Request: rubygem-chake - serverless configuration management tool for chef

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1242056



--- Comment #4 from Paulo Andrade <paulo.cesar.pereira.de.andrade at gmail.com> ---
Some extra comments. I see you were following documentation :)
Since I am actually not much experienced with ruby, I was
checking all build stages, and noticed that %gem_install
receives a -d argument, that would avoid installing under
%_builddir and then copying to %buildroot, but I just found,
again, the problems described at
http://fedoraproject.org/wiki/Archive:PackagingDrafts/RubyGem_with_C_code
e.g.
Binary file
/home/pcpa/rpmbuild/BUILDROOT/rubygem-chake-0.7-1.fc23.x86_64/usr/share/gems/doc/chake-0.7/rdoc/js/searcher.js.gz
matches

Properly fixing it, e.g. by somehow using the --build-root
option would require changing/patching gem itself. So, it is
not an issue for the review.

I noticed another issue, this time in fedora-review ruby plugin,
that has a regex for '^.*gem\s+install', that matches the
"gem install" text inside a comment, so, this, along with comments
about behaviour of %gem_install could be a long time TODO, as you
become more involved with Fedora ruby packages :)


Summarizing.

Please fix:

[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required

    The line

    find %{buildroot}%{gem_instdir}/bin -type f | xargs chmod a+x

    does not appear to be required as well, for this specific package.


Please comment:

[?]: Development files must be in a -devel package

   Can you guarantee all files installed are required for runtime? Or
some are only need for development?


Note, when submitting an update, please bump the Release and add the
changes to the %changelog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component