[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1241919



--- Comment #19 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal at gmx.net> ---
Using %py3dir is unclean.

See
https://fedoraproject.org/w/index.php?title=Packaging%3APython&diff=405394&oldid=404468
[ https://fedorahosted.org/fpc/ticket/435 ]



> %attr(0755, root, root) %{python2_sitearch}/*.so

These are very ordinary permissions for such a *.so file. Especially
"root,root" is a default.

If the %install section doesn't get the permissions within the %buildroot
right, it ought to get fixed upstream (e.g. via "install -m…")and temporarily
in %install. In the same way you would chmod -x files not meant to be executed,
such as source files, README files, license texts. If the %install section gets
it right already, it's overuse of %attr here.

Please restrict %attr usage to really _special_ cases, such as setuid/setgid,
and non-root ownership. Those are the cases when you want special attributes to
_stick out_ when displaying the spec file. In addition to that, if it were a
larger package with lots of files in several subpackages, having to add %attr
everywhere would be a burden and would decrease readability.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component