[Bug 1242724] Review Request: perl-File-Find-Rule-Age - Rule to match on file age

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1242724



--- Comment #1 from Petr Šabata <psabata at redhat.com> ---
Nothing really new here so I'll be brief.  I explained all these in the other
review :)   I'll assume this one is going into EL6+ as well.


* The BuildRoot tag can be dropped.

* The perl version constraint can be dropped.

* Missing buildtime dependencies: coreutils, findutils, make
  All of these are called in the specfile.

* Missing perl buildtime dependencies:
  - base, lib/File/Find/Rule/Age.pm:8
  - Carp, lib/File/Find/Rule/Age.pm:10
  - File::stat, lib/File/Find/Rule/Age.pm:12
  - FindBin, t/01-legacy.t:6 t/02-accessed.t:6 t/02-created.t:6
t/02-modified.t:6
  - strict, Makefile.PL:1
  - warnings, Makefile.PL:2

 The lib/* and t/* deps are needed because you run the test suite (good!).

* You should filter out the autogenerated unversioned runtime dependencies on
DateTime, File::Find::Rule and Params::Util.  For example like so:

%global __requires_exclude ^perl\\(DateTime|File::Find::Rule|Params::Util\\)$

* There's no need to clean the buildroot (line 40), remove the emtpy
directories (line 45), for the %clean section (lines 52-53) or for %defattr
(line 56).

* You may substitute PERL_INSTALL_ROOT with DESTDIR.

* Don't package upstream distribution metadata, META.json, in %doc.

* Correct the changelog header (missing e-mail address).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component