[Bug 1239273] Review Request: golang-github-BurntSushi-toml-test - Language agnostic test suite for TOML

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1239273

Jonathan Underwood <jonathan.underwood at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #20 from Jonathan Underwood <jonathan.underwood at gmail.com> ---
OK, great, am going to mark this as APPROVED. Many thanks to you both for your
hard work on this, a really nice contribution to Fedora.

As an aside, the indentation you've added for the %if'd stuff in %files is very
unusual for spec files (unike pretty much any other language). I don't think it
should be causing an issue with rpmbuild, but it may confuse other tools people
use, so I would encourage you not to indent like that. But there's no hard rule
on it, so I am not going to insist.

Presumably at this point, other toml parsers in Fedora can now use this test
suite in their %check - it'd be nice to file bugs against any other toml
parsers asking them to enable such functionality.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component