[Bug 1245929] Review Request: platform - Platform support library used by libCEC and binary add-ons for Kodi

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1245929



--- Comment #2 from Mohamed El Morabity <pikachu.2014 at gmail.com> ---
(In reply to Michael Cronenworth from comment #1)
> 1. License file is missing. You can add one and open a request for upstream
> to include it.
Upstream provides a copyright file in the debian/ subfolder, probably to meet
Debian's packaging guidelines. I should use it since it's already available.

> 2. licensecheck reveals BSD and LGPL licensed files, and also many files
> using an incorrect FSF address. You can ask upstream to update their license
> clauses and add the missing licenses to the spec.
The BSD headers are only used when platform is built on Windows.

By the way, two issues detected by a Debian packager may impact this review:
1) licensing issue:
       https://github.com/Pulse-Eight/platform/issues/12
2) bundled library I missed (fstrcmp):
       https://github.com/Pulse-Eight/platform/issues/13
   Unbundling this library may solve the licensing conflict above (since latest
versions seem to be full-GPLv2+).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component