[Bug 1244510] Review Request: python-txaio - Compatibility API between asyncio/Twisted/Trollius

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1244510

Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> ---
(In reply to Julien Enselme from comment #3)
> I won't use %autosetup as I had problem with line endings when I tried to
> use it on this package.
I think it has a bug where you have to insert a blank line after the macro in
the spec file. I think that bug was fixed at some point, and is only present in
stable fedora branches.

> - Add provides for python2-txaio
> - Remove usage of python2 and python3 dirs
> - Unbundle jquery
You will need Requires: js-jquery in the -doc subpackage.

> - Don't remove _sources of documentation
> 
> 
> SPEC:
> http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-txaio.spec
> SRPM:
> http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-txaio-1.0.0-
> 3.fc22.src.rpm

- license is OK (MIT)
- latest version is packaged
- fs layout is OK
- spec file is nice and clean
- license file is present and %license macro is used
- egg info handling is OK
- rpmlint contains only false positives
- Requires and Provides almost OK, see ISSUES below

Rpmlint:
python-txaio.noarch: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-txaio.noarch: W: spelling-error %description -l en_US asyncio ->
Asuncion
python3-txaio.noarch: W: spelling-error Summary(en_US) asyncio -> Asuncion
python3-txaio.noarch: W: spelling-error %description -l en_US asyncio ->
Asuncion
python-txaio-doc.noarch: W: spelling-error %description -l en_US asyncio ->
Asuncion
python-txaio-doc.noarch: W: file-not-utf8
/usr/share/doc/python-txaio-doc/html/objects.inv
python-txaio-doc.noarch: W: dangling-symlink
/usr/share/doc/python-txaio-doc/html/_static/jquery.js
/usr/share/javascript/jquery/latest/jquery.min.js
python-txaio-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-txaio-doc/html/_sources/api.txt
python-txaio-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-txaio-doc/html/_sources/overview.txt
python-txaio-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-txaio-doc/html/_sources/index.txt
python-txaio.src: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-txaio.src: W: spelling-error %description -l en_US asyncio -> Asuncion
4 packages and 0 specfiles checked; 0 errors, 12 warnings.

ISSUES:
Provides: python2-txaio is missing.
Requires: js-jquery is missing.

Please fix that. Package is APPROVED.


--
Note: python guidelines are being updated, but the changes were not announced
yet.
In case of this package the changes will be fairly cosmetic, so they can
be left for later, after the guidelines changes have stabilized and have been
formally announced.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component