[Bug 1213065] Review Request: hexer - ncurses-based binary editor

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1213065



--- Comment #5 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal at gmx.net> ---
Try pointing the fedora-review tool at this ticket: fedora-review -b 1213065
It evaluates the "Spec URL:" and "SRPM URL:" lines, downloads the latest
packages, performs local test-builds and many checks related to the packaging
guidelines.


> please remove "_v1" postfix after download

The better choice would have been to practice increasing "Release" for each
package update:

  https://fedoraproject.org/wiki/Packaging:FrequentlyMadeMistakes

 | Increase the "Release" tag every time you upload a new package to avoid
 | confusion. The reviewer and other interested parties probably still have 
 | older versions of your SRPM lying around to check what has changed between
 | the old and new packages; those get confused when the revision didn't 
 | change. 


> License: BSD

A modified 3-clause BSD that adds a specific requirement for documenting
changes in the README and the source files.

Not really a hurdle for the current patch but can be easy to miss.


> cc -O -DHEXER_VERSION=\"0.1.8\"  -c -o buffer.o buffer.c

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

rpmlint:
hexer-debuginfo.x86_64: E: debuginfo-without-sources

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component