[Bug 1178162] Review Request: springframework-data-commons - Interfaces and code shared between the various datastore specific implementations

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1178162

Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Jerry James <loganjerry at gmail.com> ---
There are a few small SHOULD issues, which do not block approval, namely:
- Patches link to upstream bugs/comments/lists or are otherwise justified.
- The spec file in the link and the spec file in the source rpm differ, so be
sure to check in the right one.
- If you want to preserve timestamps on license.txt and notice.txt, replace
these two lines in %prep:

cp -p src/main/resources/*.txt .
sed -i 's/\r//' *.txt

with these lines:

cp -p src/main/resources/*.txt .
sed -i.orig 's/\r//' *.txt
touch -r license.txt.orig license.txt
touch -r notice.txt.orig notice.txt

This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component